1. 28 Oct, 2017 1 commit
    • Remy Suen's avatar
      Expose JavaScript function name in thrown error · 63f2dac2
      Remy Suen authored
      When an error happens in libgit2, NodeGit will wrap the and expose
      the error code and message to be consumed via the JavaScript API.
      However, this information is often insufficient given the
      asynchronous nature of NodeGit and it may at times be unclear as to
      which JavaScript function caused the error on the libgit2 side. By
      exposing an 'errorFunction' property string that includes the name of
      the JavaScript function in the error, debugging should now be a lot
      easier as clients will now be able to quickly identify which
      JavaScript function in a long promise chain was the source of an
      error.
      Signed-off-by: default avatarRemy Suen <remy.suen@gmail.com>
      63f2dac2
  2. 12 Sep, 2017 2 commits
  3. 15 Aug, 2017 1 commit
  4. 14 Aug, 2017 1 commit
  5. 02 Aug, 2017 1 commit
  6. 31 Jul, 2017 1 commit
  7. 25 Jul, 2017 6 commits
  8. 28 Feb, 2017 1 commit
  9. 15 Feb, 2017 1 commit
  10. 13 Feb, 2017 3 commits
  11. 09 Feb, 2017 1 commit
  12. 08 Feb, 2017 1 commit
  13. 07 Feb, 2017 4 commits
  14. 06 Feb, 2017 1 commit
  15. 01 Feb, 2017 1 commit
    • Remy Suen's avatar
      Initialize pointers to prevent warnings during initial assignment · cb7be7ec
      Remy Suen authored
      In convert_from_v8.cc, the unwrapping of values uses two separate lines
      of code for variable declaration and variable assignment. When a
      pointer (or double pointer) is present, the assignment to the newly
      declared variable creates a compiler warning. To prevent the
      compilation logs from filling up unnecessarily, pointer variables
      should initially be assigned a `NULL` value upon its declaration so
      that the compiler will not emit a warning on the subseqent variable
      assignment line.
      cb7be7ec
  16. 31 Jan, 2017 1 commit
    • Remy Suen's avatar
      Expose libgit2 error code to clients when a promise fails · 8f911102
      Remy Suen authored
      When an API function of libgit2 fails within a promise, the promise is
      rejected with a JavaScript Error object that wraps the recorded error
      message in giterr_last(). However, the original non-zero return code of
      the API function is not exposed to the caller of the NodeGit API. This
      means that NodeGit clients cannot easily identify what the cause of an
      error is outside of parsing the Error object's message. This is
      an extremely volatile way of determining the cause as libgit2 may
      choose to alter the wording of the message at any time.
      
      To solve the problem above, the returned JavaScript Error object now
      esposes the libgit2 error code via its `errno` property.
      8f911102
  17. 30 Jan, 2017 4 commits
  18. 26 Jan, 2017 1 commit
  19. 25 Jan, 2017 1 commit
  20. 24 Jan, 2017 1 commit
  21. 07 Oct, 2016 2 commits
  22. 14 Sep, 2016 1 commit
  23. 11 Aug, 2016 2 commits
  24. 26 Jul, 2016 1 commit
    • Kyle Smith's avatar
      Memory management: duplicate time · cdc5767e
      Kyle Smith authored
      it's unsafe to use the signature's time directly since the signature could be freed. Instead duplicate the signature's time when it is requested and set it as self freeing.
      cdc5767e