1. 28 Oct, 2017 1 commit
    • Remy Suen's avatar
      Expose JavaScript function name in thrown error · 63f2dac2
      Remy Suen authored
      When an error happens in libgit2, NodeGit will wrap the and expose
      the error code and message to be consumed via the JavaScript API.
      However, this information is often insufficient given the
      asynchronous nature of NodeGit and it may at times be unclear as to
      which JavaScript function caused the error on the libgit2 side. By
      exposing an 'errorFunction' property string that includes the name of
      the JavaScript function in the error, debugging should now be a lot
      easier as clients will now be able to quickly identify which
      JavaScript function in a long promise chain was the source of an
      error.
      Signed-off-by: default avatarRemy Suen <remy.suen@gmail.com>
      63f2dac2
  2. 31 Jul, 2017 1 commit
  3. 25 Jul, 2017 3 commits
  4. 28 Feb, 2017 1 commit
  5. 15 Feb, 2017 1 commit
  6. 13 Feb, 2017 3 commits
  7. 09 Feb, 2017 1 commit
  8. 08 Feb, 2017 1 commit
  9. 07 Feb, 2017 4 commits
  10. 06 Feb, 2017 1 commit
  11. 31 Jan, 2017 1 commit
    • Remy Suen's avatar
      Expose libgit2 error code to clients when a promise fails · 8f911102
      Remy Suen authored
      When an API function of libgit2 fails within a promise, the promise is
      rejected with a JavaScript Error object that wraps the recorded error
      message in giterr_last(). However, the original non-zero return code of
      the API function is not exposed to the caller of the NodeGit API. This
      means that NodeGit clients cannot easily identify what the cause of an
      error is outside of parsing the Error object's message. This is
      an extremely volatile way of determining the cause as libgit2 may
      choose to alter the wording of the message at any time.
      
      To solve the problem above, the returned JavaScript Error object now
      esposes the libgit2 error code via its `errno` property.
      8f911102
  12. 30 Jan, 2017 3 commits
  13. 11 Aug, 2016 2 commits
  14. 26 Jul, 2016 1 commit
    • Kyle Smith's avatar
      Memory management: duplicate time · cdc5767e
      Kyle Smith authored
      it's unsafe to use the signature's time directly since the signature could be freed. Instead duplicate the signature's time when it is requested and set it as self freeing.
      cdc5767e
  15. 17 May, 2016 1 commit
  16. 11 May, 2016 1 commit
  17. 05 May, 2016 1 commit
  18. 09 Apr, 2016 1 commit
    • Stjepan Rajko's avatar
      Factor out base class for structs / classes with cType · e15808a4
      Stjepan Rajko authored
      - Separated cpyFunction from dupFunction in descriptor (since semantics are different - only affects git_oid)
      - Added a {{ cppFunctionName }}Traits class to start leaning more on C++ templates where possible
      - Assigning `free` as `freeFunctionName` for structs (since that was the previous behavior)
      - Extracting a number of variables and methods from class_ and struct_ combyne templates into a base class (mostly dealing with construction / destruction and memory management).  This is to extend the memory management coverage that was implemented for class_ types to struct_ types.  I tried to maintain a similar .h / .cc separation that we had before.
      e15808a4
  19. 07 Apr, 2016 1 commit
  20. 02 Apr, 2016 1 commit
  21. 28 Mar, 2016 1 commit
  22. 18 Mar, 2016 1 commit
  23. 09 Mar, 2016 3 commits
  24. 07 Mar, 2016 1 commit
  25. 03 Mar, 2016 4 commits